Skip to content

📖 add info in docs: go version v1.18+ has not been supported yet #2638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2022
Merged

📖 add info in docs: go version v1.18+ has not been supported yet #2638

merged 1 commit into from
Apr 27, 2022

Conversation

@twilight0620
Copy link

@twilight0620 twilight0620 commented Apr 24, 2022

go version does not support v1.18, but docs does not expain it.
when i tried to use go v1.18.1 and kubebuilder v3.30， it has errors.
so need to add it in docs so that user can know it.

Fixes: #2623

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 24, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 24, 2022

Hi @twilight0620. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

camilamacedo86
camilamacedo86 reviewed Apr 25, 2022
View reviewed changes
docs/book/src/quick-start.md Outdated
- [go](https://golang.org/dl/) version v1.15+ (kubebuilder v3.0 < v3.1).
- [go](https://golang.org/dl/) version v1.16+ (kubebuilder v3.1 < v3.3).
- [go](https://golang.org/dl/) version v1.17+ (kubebuilder v3.3+).
- [go](https://golang.org/dl/) version v1.17+, v1.18+ has not been supported yet (kubebuilder v3.3+).
Copy link
Member

@camilamacedo86 camilamacedo86 Apr 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [go](https://golang.org/dl/) version v1.17+, v1.18+ has not been supported yet (kubebuilder v3.3+).
- [go](https://golang.org/dl/) version v1.17+ < v1.18 (kubebuilder v3.3+).

It shows for me enough. WDYT

Copy link
Author

@twilight0620 twilight0620 Apr 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have modified it .

camilamacedo86
camilamacedo86 reviewed Apr 26, 2022
View reviewed changes
docs/book/src/quick-start.md
- [go](https://golang.org/dl/) version v1.15+ (kubebuilder v3.0 < v3.1).
- [go](https://golang.org/dl/) version v1.16+ (kubebuilder v3.1 < v3.3).
- [go](https://golang.org/dl/) version v1.17+ (kubebuilder v3.3+).
- [go](https://golang.org/dl/) version v1.17+ < v1.18 (kubebuilder v3.3+).
Copy link
Member

@camilamacedo86 camilamacedo86 Apr 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit could you please squash the commits then we are OK here to get this one merged.
@twilight0620 Thank you for your contribution 🥇

Copy link
Author

@twilight0620 twilight0620 Apr 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

camilamacedo86
camilamacedo86 approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approved
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 27, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, twilight0620

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2022
@k8s-ci-robot k8s-ci-robot merged commit 61b263c into kubernetes-sigs:master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@camilamacedo86 camilamacedo86

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

go version not supprot 1.18, but docs does not say it.

3 participants

@twilight0620 @k8s-ci-robot @camilamacedo86